liyong
10 小时以前 7a23c450f3ac85de7dca1b908de273ff636ce218
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
package cn.iocoder.yudao.module.im.service.message;
 
import cn.hutool.core.collection.ListUtil;
import cn.iocoder.yudao.framework.common.exception.ServiceException;
import cn.iocoder.yudao.framework.test.core.ut.BaseMockitoUnitTest;
import cn.iocoder.yudao.module.im.controller.admin.message.vo.privates.ImPrivateMessageListReqVO;
import cn.iocoder.yudao.module.im.controller.admin.message.vo.privates.ImPrivateMessageSendReqVO;
import cn.iocoder.yudao.module.im.dal.dataobject.message.ImPrivateMessageDO;
import cn.iocoder.yudao.module.im.dal.mysql.message.ImPrivateMessageMapper;
import cn.iocoder.yudao.module.im.enums.ImConversationTypeEnum;
import cn.iocoder.yudao.module.im.enums.message.ImMessageReceiptStatusEnum;
import cn.iocoder.yudao.module.im.enums.message.ImMessageStatusEnum;
import cn.iocoder.yudao.module.im.enums.ImContentTypeEnum;
import cn.iocoder.yudao.module.im.framework.config.ImProperties;
import cn.iocoder.yudao.module.im.service.conversation.ImConversationReadService;
import cn.iocoder.yudao.module.im.service.friend.ImFriendService;
import cn.iocoder.yudao.module.im.service.sensitiveword.ImSensitiveWordService;
import cn.iocoder.yudao.module.im.service.message.dto.ImPrivateMessageSendDTO;
import cn.iocoder.yudao.module.im.service.websocket.ImWebSocketService;
import cn.iocoder.yudao.module.im.service.websocket.notification.message.ImMessageReadNotification;
import cn.iocoder.yudao.module.im.service.websocket.notification.message.ImMessageReceiptNotification;
import cn.iocoder.yudao.module.im.service.websocket.notification.message.ImPrivateMessageNotification;
import cn.iocoder.yudao.module.im.dal.dataobject.message.content.RecallMessage;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Spy;
 
import java.time.LocalDateTime;
import java.util.List;
 
import static cn.iocoder.yudao.module.im.enums.ErrorCodeConstants.*;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
 
/**
 * {@link ImPrivateMessageServiceImpl} 的单元测试
 *
 * @author 芋道源码
 */
public class ImPrivateMessageServiceImplTest extends BaseMockitoUnitTest {
 
    @InjectMocks
    private ImPrivateMessageServiceImpl privateMessageService;
 
    @Mock
    private ImPrivateMessageMapper privateMessageMapper;
    @Mock
    private ImFriendService friendService;
    @Mock
    private ImSensitiveWordService sensitiveWordService;
    @Mock
    private ImConversationReadService conversationReadService;
    @Mock
    private ImWebSocketService imWebSocketService;
 
    @Spy
    private ImProperties imProperties = new ImProperties();
 
    private ImPrivateMessageSendReqVO buildSendReqVO() {
        ImPrivateMessageSendReqVO reqVO = new ImPrivateMessageSendReqVO();
        reqVO.setClientMessageId("test-uuid-001");
        reqVO.setReceiverId(2L);
        reqVO.setType(ImContentTypeEnum.TEXT.getType());
        reqVO.setContent("{\"content\":\"你好\"}");
        return reqVO;
    }
 
    // ========== 发送测试 ==========
 
    @Test
    public void testSendMessage_success() {
        // 准备
        ImPrivateMessageSendReqVO reqVO = buildSendReqVO();
        when(privateMessageMapper.selectBySenderIdAndClientMessageId(1L, "test-uuid-001"))
                .thenReturn(null);
        when(privateMessageMapper.insert(any(ImPrivateMessageDO.class))).thenAnswer(invocation -> {
            ImPrivateMessageDO msg = invocation.getArgument(0);
            msg.setId(99L);
            return 1;
        });
 
        // 调用
        ImPrivateMessageDO result = privateMessageService.sendPrivateMessage(1L, reqVO);
 
        // 断言
        assertNotNull(result);
        assertEquals(1L, result.getSenderId());
        assertEquals(2L, result.getReceiverId());
        assertEquals(ImContentTypeEnum.TEXT.getType(), result.getType());
        assertEquals(ImMessageStatusEnum.NORMAL.getStatus(), result.getStatus());
        assertEquals(ImMessageReceiptStatusEnum.PENDING.getStatus(), result.getReceiptStatus(),
                "用户私聊消息默认需要回执(PENDING)");
        assertNotNull(result.getSendTime());
 
        // 验证调用
        verify(friendService).validateFriend(1L, 2L);
        verify(sensitiveWordService).validateText(reqVO.getContent());
        verify(privateMessageMapper).insert(any(ImPrivateMessageDO.class));
        // 验证推送给接收方和发送方
        verify(imWebSocketService).sendNotificationAsync(eq(2L), anyInt(), anyInt(), any());
        verify(imWebSocketService).sendNotificationAsync(eq(1L), anyInt(), anyInt(), any());
    }
 
    @Test
    public void testSendMessage_clientMessageIdIdempotent() {
        // 准备:模拟已存在消息
        ImPrivateMessageSendReqVO reqVO = buildSendReqVO();
        ImPrivateMessageDO existingMessage = ImPrivateMessageDO.builder()
                .id(100L).clientMessageId("test-uuid-001").senderId(1L).receiverId(2L)
                .type(0).content("{\"content\":\"你好\"}").status(0)
                .sendTime(LocalDateTime.now()).build();
        when(privateMessageMapper.selectBySenderIdAndClientMessageId(1L, "test-uuid-001"))
                .thenReturn(existingMessage);
 
        // 调用
        ImPrivateMessageDO result = privateMessageService.sendPrivateMessage(1L, reqVO);
 
        // 断言:返回已存在的消息
        assertEquals(100L, result.getId());
        // 验证不会重复插入
        verify(privateMessageMapper, never()).insert(any(ImPrivateMessageDO.class));
    }
 
    @Test
    public void testSendMessage_notFriend() {
        // 准备
        ImPrivateMessageSendReqVO reqVO = buildSendReqVO();
        when(privateMessageMapper.selectBySenderIdAndClientMessageId(1L, "test-uuid-001"))
                .thenReturn(null);
        doThrow(new ServiceException(FRIEND_NOT_FRIEND))
                .when(friendService).validateFriend(1L, 2L);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.sendPrivateMessage(1L, reqVO));
        assertEquals(FRIEND_NOT_FRIEND.getCode(), exception.getCode());
    }
 
    // ========== pull 测试 ==========
 
    @Test
    public void testPullMessages_success() {
        // 准备
        List<ImPrivateMessageDO> mockMessages = ListUtil.of(
                ImPrivateMessageDO.builder().id(1L).senderId(1L).receiverId(2L).build(),
                ImPrivateMessageDO.builder().id(2L).senderId(2L).receiverId(1L).build()
        );
        when(privateMessageMapper.selectListByMinId(eq(1L), eq(0L), any(LocalDateTime.class), eq(100)))
                .thenReturn(mockMessages);
 
        // 调用
        List<ImPrivateMessageDO> result = privateMessageService.pullPrivateMessageList(1L, 0L, 100);
 
        // 断言
        assertEquals(2, result.size());
    }
 
    @Test
    public void testPullMessages_sizeExceeded() {
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.pullPrivateMessageList(1L, 0L, 1001));
        assertEquals(MESSAGE_PULL_SIZE_EXCEEDED.getCode(), exception.getCode());
    }
 
    // ========== 已读测试 ==========
 
    @Test
    public void testReadMessages_success() {
        // 准备:前端上报已读到 messageId=5;mapper 返回更新行数 2 表示有待回执消息被标记完成
        when(privateMessageMapper.updateBySenderIdAndReceiverIdAndIdLeAndReceiptStatus(
                eq(2L), eq(1L), eq(5L),
                eq(ImMessageReceiptStatusEnum.PENDING.getStatus()), any(ImPrivateMessageDO.class)))
                .thenReturn(2);
        // 读位置前进 → 才下发事件
        when(conversationReadService.updateConversationReadPosition(anyLong(), anyInt(), anyLong(), anyLong()))
                .thenReturn(true);
 
        // 调用
        privateMessageService.readPrivateMessages(1L, 2L, 5L);
 
        // 断言:把待回执(PENDING)消息标记为已完成(DONE);status 不再写 READ
        verify(privateMessageMapper).updateBySenderIdAndReceiverIdAndIdLeAndReceiptStatus(
                eq(2L), eq(1L), eq(5L),
                eq(ImMessageReceiptStatusEnum.PENDING.getStatus()), any(ImPrivateMessageDO.class));
 
        // 断言:发送了 READ + RECEIPT 事件,payload 字段正确
        ArgumentCaptor<Long> userCaptor = ArgumentCaptor.forClass(Long.class);
        ArgumentCaptor<Integer> contentTypeCaptor = ArgumentCaptor.forClass(Integer.class);
        ArgumentCaptor<Object> payloadCaptor = ArgumentCaptor.forClass(Object.class);
        verify(imWebSocketService, times(2)).sendNotificationAsync(
                userCaptor.capture(), eq(ImConversationTypeEnum.PRIVATE.getType()),
                contentTypeCaptor.capture(), payloadCaptor.capture());
 
        // 第一次:发给自己的 READ 事件
        assertEquals(1L, userCaptor.getAllValues().get(0));
        assertEquals(ImContentTypeEnum.READ.getType(), contentTypeCaptor.getAllValues().get(0));
        ImMessageReadNotification readPayload = (ImMessageReadNotification) payloadCaptor.getAllValues().get(0);
        assertEquals(1L, readPayload.getSenderId());
        assertEquals(2L, readPayload.getReceiverId());
        assertEquals(5L, readPayload.getId(), "READ id 应为前端上报的 messageId");
 
        // 第二次:发给对方的 RECEIPT 事件
        assertEquals(2L, userCaptor.getAllValues().get(1));
        assertEquals(ImContentTypeEnum.RECEIPT.getType(), contentTypeCaptor.getAllValues().get(1));
        ImMessageReceiptNotification receiptPayload =
                (ImMessageReceiptNotification) payloadCaptor.getAllValues().get(1);
        assertEquals(5L, receiptPayload.getId(), "RECEIPT id 应为前端上报的 messageId");
    }
 
    // ========== 撤回测试 ==========
 
    @Test
    public void testRecallMessage_success() {
        // 准备
        ImPrivateMessageDO message = ImPrivateMessageDO.builder()
                .id(10L).senderId(1L).receiverId(2L)
                .status(ImMessageStatusEnum.NORMAL.getStatus())
                .sendTime(LocalDateTime.now()).build(); // 刚发送,5 分钟内
        when(privateMessageMapper.selectById(10L)).thenReturn(message);
        when(privateMessageMapper.updateById(any(ImPrivateMessageDO.class))).thenReturn(1);
        when(privateMessageMapper.insert(any(ImPrivateMessageDO.class))).thenReturn(1);
 
        // 调用
        ImPrivateMessageDO result = privateMessageService.recallPrivateMessage(1L, 10L);
 
        // 断言:返回撤回消息
        assertNotNull(result);
        // 验证:更新原消息状态 + 插入 RecallMessage
        verify(privateMessageMapper).updateById(any(ImPrivateMessageDO.class));
        verify(privateMessageMapper).insert(any(ImPrivateMessageDO.class));
        // 验证推送了消息(给接收方和发送方)
        verify(imWebSocketService, times(2)).sendNotificationAsync(anyLong(), anyInt(), anyInt(), any());
    }
 
    @Test
    public void testRecallMessage_notOwn() {
        // 准备
        ImPrivateMessageDO message = ImPrivateMessageDO.builder()
                .id(10L).senderId(2L).receiverId(1L)
                .status(ImMessageStatusEnum.NORMAL.getStatus())
                .sendTime(LocalDateTime.now()).build();
        when(privateMessageMapper.selectById(10L)).thenReturn(message);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.recallPrivateMessage(1L, 10L));
        assertEquals(MESSAGE_RECALL_DENIED.getCode(), exception.getCode());
    }
 
    @Test
    public void testRecallMessage_alreadyRecalled() {
        // 准备
        ImPrivateMessageDO message = ImPrivateMessageDO.builder()
                .id(10L).senderId(1L).receiverId(2L)
                .status(ImMessageStatusEnum.RECALL.getStatus())
                .sendTime(LocalDateTime.now()).build();
        when(privateMessageMapper.selectById(10L)).thenReturn(message);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.recallPrivateMessage(1L, 10L));
        assertEquals(MESSAGE_ALREADY_RECALLED.getCode(), exception.getCode());
    }
 
    @Test
    public void testRecallMessage_notExists() {
        // 准备
        when(privateMessageMapper.selectById(10L)).thenReturn(null);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.recallPrivateMessage(1L, 10L));
        assertEquals(MESSAGE_NOT_EXISTS.getCode(), exception.getCode());
    }
 
    @Test
    public void testRecallMessage_timeout() {
        // 准备:消息发送于 10 分钟前(超过 5 分钟窗口)
        ImPrivateMessageDO message = ImPrivateMessageDO.builder()
                .id(10L).senderId(1L).receiverId(2L)
                .status(ImMessageStatusEnum.NORMAL.getStatus())
                .sendTime(LocalDateTime.now().minusMinutes(10)).build();
        when(privateMessageMapper.selectById(10L)).thenReturn(message);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.recallPrivateMessage(1L, 10L));
        assertEquals(MESSAGE_RECALL_TIMEOUT.getCode(), exception.getCode());
        // 断言:不推送、不插 tipMessage
        verify(privateMessageMapper, never()).insert(any(ImPrivateMessageDO.class));
    }
 
    @Test
    public void testSendMessage_sensitiveWordBlocked() {
        // 准备:文本消息命中敏感词
        ImPrivateMessageSendReqVO reqVO = buildSendReqVO();
        when(privateMessageMapper.selectBySenderIdAndClientMessageId(1L, "test-uuid-001"))
                .thenReturn(null);
        doThrow(new ServiceException(MESSAGE_SENSITIVE_WORD_BLOCKED))
                .when(sensitiveWordService).validateText(reqVO.getContent());
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.sendPrivateMessage(1L, reqVO));
        assertEquals(MESSAGE_SENSITIVE_WORD_BLOCKED.getCode(), exception.getCode());
        // 断言:不入库、不推送
        verify(privateMessageMapper, never()).insert(any(ImPrivateMessageDO.class));
        verify(imWebSocketService, never()).sendNotificationAsync(anyLong(), anyInt(), anyInt(), any());
    }
 
    @Test
    public void testReadMessages_disabled() {
        // 准备:关闭私聊已读
        imProperties.getMessage().setPrivateReadEnabled(false);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.readPrivateMessages(1L, 2L, 5L));
        assertEquals(MESSAGE_PRIVATE_READ_DISABLED.getCode(), exception.getCode());
        // 断言:不更新消息状态、不推送
        verify(privateMessageMapper, never()).updateBySenderIdAndReceiverIdAndIdLeAndReceiptStatus(
                anyLong(), anyLong(), anyLong(), anyInt(), any(ImPrivateMessageDO.class));
        verify(imWebSocketService, never()).sendNotificationAsync(anyLong(), anyInt(), anyInt(), any());
    }
 
    @Test
    public void testReadMessages_notAdvanced() {
        // 准备:读位置未前进(已读过 / CAS 失败),不下发事件
        when(conversationReadService.updateConversationReadPosition(anyLong(), anyInt(), anyLong(), anyLong()))
                .thenReturn(false);
 
        // 调用
        privateMessageService.readPrivateMessages(1L, 2L, 5L);
 
        // 断言:读位置没前进,不推送 READ / RECEIPT
        verify(imWebSocketService, never()).sendNotificationAsync(anyLong(), anyInt(), anyInt(), any());
    }
 
    // ========== getMaxReadMessageId 测试 ==========
 
    @Test
    public void testGetMaxReadMessageId_hit() {
        // 准备:对方(2) 在与我(1) 的会话里读位置=10
        when(conversationReadService.getConversationReadMessageId(eq(2L), anyInt(), eq(1L)))
                .thenReturn(10L);
 
        // 调用
        Long result = privateMessageService.getMaxReadMessageId(1L, 2L);
 
        // 断言
        assertEquals(10L, result);
    }
 
    @Test
    public void testGetMaxReadMessageId_miss() {
        // 准备:对方一条都没读过(读位置为 null)
        when(conversationReadService.getConversationReadMessageId(eq(2L), anyInt(), eq(1L)))
                .thenReturn(null);
 
        // 调用
        Long result = privateMessageService.getMaxReadMessageId(1L, 2L);
 
        // 断言:原样返回 null,前端按 falsy 跳过
        assertNull(result);
    }
 
    @Test
    public void testGetMaxReadMessageId_disabled() {
        // 准备:关闭私聊已读
        imProperties.getMessage().setPrivateReadEnabled(false);
 
        // 调用并断言
        ServiceException exception = assertThrows(ServiceException.class,
                () -> privateMessageService.getMaxReadMessageId(1L, 2L));
        assertEquals(MESSAGE_PRIVATE_READ_DISABLED.getCode(), exception.getCode());
    }
 
    // ========== DTO 私聊消息 ==========
 
    @Test
    public void testSendPrivateMessage_dto_persistsAndSerializesPojoContent() {
        // 准备:persistent=true 类型 + POJO content
        ImPrivateMessageSendDTO dto = new ImPrivateMessageSendDTO()
                .setReceiverId(2L).setType(ImContentTypeEnum.RECALL.getType())
                .setContent(new RecallMessage().setMessageId(50L));
 
        privateMessageService.sendPrivateMessage(1L, dto);
 
        // 断言:入库 + 系统字段兜底 + content 序列化为 JSON
        ArgumentCaptor<ImPrivateMessageDO> captor = ArgumentCaptor.forClass(ImPrivateMessageDO.class);
        verify(privateMessageMapper).insert(captor.capture());
        ImPrivateMessageDO message = captor.getValue();
        assertEquals(1L, message.getSenderId());
        assertEquals(2L, message.getReceiverId());
        assertEquals(ImContentTypeEnum.RECALL.getType(), message.getType());
        assertEquals("{\"messageId\":50}", message.getContent());
        assertEquals(ImMessageStatusEnum.NORMAL.getStatus(), message.getStatus());
        assertNotNull(message.getClientMessageId());
        assertNotNull(message.getSendTime());
        // 断言:sender + receiver 双端推送
        verify(imWebSocketService).sendNotificationAsync(eq(1L), anyInt(), anyInt(), any());
        verify(imWebSocketService).sendNotificationAsync(eq(2L), anyInt(), anyInt(), any());
    }
 
    @Test
    public void testSendPrivateMessage_dto_nonPersistentTypeNotInserted() {
        // 准备:persistent=false 类型(FRIEND_DELETE 通知)→ 不入库;仅推 sender 多端,receiver 不感知
        ImPrivateMessageSendDTO dto = new ImPrivateMessageSendDTO()
                .setReceiverId(2L).setType(ImContentTypeEnum.FRIEND_DELETE.getType());
 
        privateMessageService.sendPrivateMessage(1L, dto);
 
        verify(privateMessageMapper, never()).insert(any(ImPrivateMessageDO.class));
        verify(imWebSocketService).sendNotificationAsync(eq(1L), anyInt(), anyInt(), any());
        verify(imWebSocketService, never()).sendNotificationAsync(eq(2L), anyInt(), anyInt(), any());
    }
 
    // ========== getPrivateMessageList ==========
 
    @Test
    public void testGetPrivateMessageList_delegatesToMapper() {
        // 准备
        ImPrivateMessageListReqVO reqVO = new ImPrivateMessageListReqVO();
        reqVO.setReceiverId(2L);
        reqVO.setMaxId(100L);
        reqVO.setLimit(20);
        List<ImPrivateMessageDO> mockList = ListUtil.of(
                ImPrivateMessageDO.builder().id(99L).senderId(1L).receiverId(2L).build(),
                ImPrivateMessageDO.builder().id(98L).senderId(2L).receiverId(1L).build()
        );
        when(privateMessageMapper.selectHistoryList(1L, 2L, 100L, 20)).thenReturn(mockList);
 
        // 调用
        List<ImPrivateMessageDO> result = privateMessageService.getPrivateMessageList(1L, reqVO);
 
        // 断言:透传到 mapper,参数一致
        assertEquals(2, result.size());
        verify(privateMessageMapper).selectHistoryList(1L, 2L, 100L, 20);
    }
 
}