refactor: 单据审核改为审批配置状态机（新增:audit接口/审核人字段/DB变更脚本）

liu

3 天以前 7d2ee3cef2e0d68ba6400bc5957640d2771bbf4c

 yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/stocktaking/task/MesWmStockTakingTaskServiceImpl.java

@@ -2,37 +2,65 @@

import cn.hutool.core.collection.CollUtil;
import cn.hutool.core.util.ObjUtil;
import cn.hutool.core.util.StrUtil;
import cn.iocoder.yudao.framework.common.pojo.PageResult;
import cn.iocoder.yudao.framework.common.util.object.BeanUtils;
import cn.iocoder.yudao.module.mes.controller.admin.wm.stocktaking.task.vo.MesWmStockTakingTaskPageReqVO;
import cn.iocoder.yudao.module.mes.controller.admin.wm.stocktaking.task.vo.MesWmStockTakingTaskSaveReqVO;
import cn.iocoder.yudao.module.mes.dal.dataobject.wm.stocktaking.task.MesWmStockTakingTaskDO;
import cn.iocoder.yudao.module.mes.dal.dataobject.wm.stocktaking.task.MesWmStockTakingTaskLineDO;
import cn.iocoder.yudao.module.mes.dal.dataobject.wm.stocktaking.task.MesWmStockTakingTaskResultDO;
import cn.iocoder.yudao.module.mes.dal.dataobject.wm.stocktaking.plan.MesWmStockTakingPlanDO;
import cn.iocoder.yudao.module.mes.dal.mysql.wm.stocktaking.task.MesWmStockTakingTaskMapper;
import cn.iocoder.yudao.module.mes.enums.MesBizTypeConstants;
import cn.iocoder.yudao.module.mes.enums.md.autocode.MesMdAutoCodeRuleCodeEnum;
import cn.iocoder.yudao.module.mes.enums.wm.MesWmStockTakingTaskStatusEnum;
import cn.iocoder.yudao.module.mes.enums.wm.MesWmTransactionTypeEnum;
import cn.iocoder.yudao.module.mes.service.md.autocode.MesMdAutoCodeRecordService;
import cn.iocoder.yudao.module.mes.service.wm.materialstock.MesWmMaterialStockService;
import cn.iocoder.yudao.module.mes.service.wm.stocktaking.plan.MesWmStockTakingPlanService;
import cn.iocoder.yudao.module.mes.service.wm.transaction.MesWmTransactionService;
import cn.iocoder.yudao.module.mes.service.wm.transaction.dto.MesWmTransactionSaveReqDTO;
import cn.iocoder.yudao.module.system.api.approval.ApprovalConfigApi;
import cn.iocoder.yudao.module.system.api.user.AdminUserApi;
import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO;
import jakarta.annotation.Resource;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Lazy;
import org.springframework.security.core.Authentication;
import org.springframework.security.core.context.SecurityContextHolder;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import org.springframework.validation.annotation.Validated;

import java.math.BigDecimal;
import java.time.LocalDateTime;
import java.util.List;
import java.util.Map;
import java.util.Set;

import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertList;
import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertMap;
import static cn.iocoder.yudao.framework.security.core.util.SecurityFrameworkUtils.getLoginUserId;
import static cn.iocoder.yudao.module.mes.enums.ErrorCodeConstants.*;

/**
 * MES 盘点任务 Service 实现类
 *
 * @author 芋道源码
 * @author 超级管理员
 */
@Service
@Validated
@Slf4j
public class MesWmStockTakingTaskServiceImpl implements MesWmStockTakingTaskService {

    /**
     * 盘点结果审批的业务类型编码
     *
     * 与 system_approval_config.biz_type 对应，审核人在「系统管理 - 审批配置」中维护。
     */
    private static final String STOCK_TAKING_RESULT_APPROVE_BIZ_TYPE = "stock_taking_result_approve";

    @Resource
    private MesWmStockTakingTaskMapper stockTakingTaskMapper;
@@ -49,7 +77,16 @@
    private MesWmStockTakingTaskResultService stockTakingTaskResultService;

    @Resource
    private MesWmTransactionService wmTransactionService;

    @Resource
    private MesMdAutoCodeRecordService mesMdAutoCodeRecordService;

    @Resource
    private AdminUserApi adminUserApi;

    @Resource
    private ApprovalConfigApi approvalConfigApi;

    @Override
    @Transactional(rollbackFor = Exception.class)
@@ -73,6 +110,38 @@
            stockTakingTaskLineService.generateStockTakingLines(task, true);
        }
        return task.getId();
    }

    @Override
    @Transactional(rollbackFor = Exception.class)
    public Long createStockTakingTaskFromPlan(Long planId) {
        // 1. 校验方案存在、已启用且开启定期自动生成
        MesWmStockTakingPlanDO plan = stockTakingPlanService.validateStockTakingPlanEnabled(planId);
        if (!Boolean.TRUE.equals(plan.getAutoGenerate())) {
            throw exception(WM_STOCK_TAKING_PLAN_NOT_AUTO_GENERATE);
        }

        // 2. 自动生成任务编码（规则：盘点任务编码）
        String code = mesMdAutoCodeRecordService.generateAutoCode(
                MesMdAutoCodeRuleCodeEnum.WM_STOCK_TAKING_CODE.getCode());

        // 3. 复用创建逻辑生成草稿任务（内部校验编码唯一、方案可用，并按方案生成盘点明细行）
        Long taskId = createStockTakingTask(new MesWmStockTakingTaskSaveReqVO()
                .setCode(code)
                .setName(plan.getName())
                .setTakingDate(LocalDateTime.now())
                .setType(plan.getType())
                .setUserId(getCurrentUserId())
                .setPlanId(planId)
                .setStartTime(plan.getStartTime())
                .setEndTime(plan.getEndTime())
                .setBlindFlag(plan.getBlindFlag())
                .setFrozen(plan.getFrozen())
                .setRemark("方案定期自动生成"));

        // 4. 回写本次生成时间，避免同一周期重复生成（与创建同事务）
        stockTakingPlanService.updateStockTakingPlanLastGenerateTime(planId, LocalDateTime.now());
        return taskId;
    }

    @Override
@@ -122,9 +191,8 @@
            throw exception(WM_STOCK_TAKING_TASK_NO_LINE);
        }

        // 2. 更新任务状态为审批中
        stockTakingTaskMapper.updateById(new MesWmStockTakingTaskDO().setId(id)
                .setStatus(MesWmStockTakingTaskStatusEnum.APPROVING.getStatus()));
        // 2. 更新任务状态为盘点中，并清空审核标记
        stockTakingTaskMapper.submitAndResetAuditInfo(id, MesWmStockTakingTaskStatusEnum.APPROVING.getStatus());

        // 3. 根据冻结标识，对物资进行冻结
        if (Boolean.TRUE.equals(task.getFrozen())) {
@@ -134,19 +202,100 @@

    @Override
    @Transactional(rollbackFor = Exception.class)
    public void finishStockTakingTask(Long id) {
        // 1. 校验任务存在且为审批中状态
    public void submitStockTakingResultApproval(Long id) {
        // 1.1 校验任务存在且处于盘点中状态
        MesWmStockTakingTaskDO task = validateStockTakingTaskExistsAndApproving(id);

        // 2. 更新任务状态为已完成
        stockTakingTaskMapper.updateById(new MesWmStockTakingTaskDO().setId(id)
                .setStatus(MesWmStockTakingTaskStatusEnum.FINISHED.getStatus()));

        // 3. 解冻库存
        if (Boolean.TRUE.equals(task.getFrozen())) {
            List<MesWmStockTakingTaskLineDO> lines = stockTakingTaskLineService.getStockTakingTaskLineListByTaskId(id);
            updateMaterialStockFrozen(lines, false);
        // 1.2 校验本轮结果审批未提交过（避免重复提交）
        if (isResultApprovalPending(task)) {
            throw exception(WM_STOCK_TAKING_TASK_ALREADY_SUBMIT_APPROVAL);
        }
        // 1.3 校验至少有一条盘点结果
        List<MesWmStockTakingTaskResultDO> results = stockTakingTaskResultService.getStockTakingTaskResultListByTaskId(id);
        if (CollUtil.isEmpty(results)) {
            throw exception(WM_STOCK_TAKING_TASK_NO_RESULT);
        }
        // 1.4 校验审批配置已启用且配置了有效审核人（未配置时抛出带明确提示的业务异常）
        approvalConfigApi.validateApprovalEnabledAndGetApprovers(STOCK_TAKING_RESULT_APPROVE_BIZ_TYPE);

        // 2. 记录提交时间并清空上一轮审核结果（任务保持盘点中，等待审核）
        stockTakingTaskMapper.markResultApprovalSubmitted(id);
    }

    @Override
    public Set<Long> getStockTakingTaskApproverUserIds() {
        return approvalConfigApi.getApproverUserIds(STOCK_TAKING_RESULT_APPROVE_BIZ_TYPE);
    }

    @Override
    @Transactional(rollbackFor = Exception.class)
    public void auditStockTakingResult(Long id, Boolean pass, String reviewRemark) {
        // 1. 校验任务存在
        MesWmStockTakingTaskDO task = validateStockTakingTaskExists(id);
        // 2. 校验处于盘点中（含结果审批中）状态
        if (!MesWmStockTakingTaskStatusEnum.APPROVING.getStatus().equals(task.getStatus())) {
            throw exception(WM_STOCK_TAKING_TASK_NOT_APPROVING);
        }
        // 3. 校验本轮结果审批已提交且尚未审核
        if (!isResultApprovalPending(task)) {
            throw exception(WM_STOCK_TAKING_TASK_RESULT_NOT_SUBMITTED);
        }
        // 4. 校验当前登录用户是该业务类型的审核人（或签：任一人均可审核）
        Long userId = getLoginUserId();
        approvalConfigApi.validateApprover(STOCK_TAKING_RESULT_APPROVE_BIZ_TYPE, userId);
        // 5. 审核不通过：必须填写原因，任务保持盘点中，可修改实盘后重新提交结果审批
        if (!Boolean.TRUE.equals(pass)) {
            if (StrUtil.isBlank(reviewRemark)) {
                throw exception(WM_STOCK_TAKING_TASK_REJECT_REASON_REQUIRED);
            }
            stockTakingTaskMapper.auditStockTakingTask(id, MesWmStockTakingTaskStatusEnum.APPROVING.getStatus(),
                    userId, getUserNickname(userId), reviewRemark);
            return;
        }
        // 6. 审核通过：先置为已完成并记录审核人与审核意见
        stockTakingTaskMapper.auditStockTakingTask(id, MesWmStockTakingTaskStatusEnum.FINISHED.getStatus(),
                userId, getUserNickname(userId), reviewRemark);
        // 7. 解冻库存：须在差异核销前解冻，否则核销事务会被库存冻结校验拦截
        if (Boolean.TRUE.equals(task.getFrozen())) {
            updateMaterialStockFrozen(stockTakingTaskLineService.getStockTakingTaskLineListByTaskId(id), false);
        }
        // 8. 自动核销盘点差异：盘盈入库 / 盘亏出库，同事务内更新库存台账；任一步失败整体回滚，任务回退为盘点中
        doProcessStockTakingDifference(task);
    }

    /**
     * 判断本轮盘点结果审批是否已提交且尚未审核
     *
     * 任务状态 2（盘点中）同时承载「盘点中」与「盘点结果审批中」两个阶段，
     * 以 reviewTime 非空且 reviewerId 为空作为「已提交、等待审核」的判定条件；
     * 审核不通过后 reviewerId 非空，任务回到可重新提交结果审批的状态。
     *
     * @param task 盘点任务
     * @return 是否处于结果审批中
     */
    private boolean isResultApprovalPending(MesWmStockTakingTaskDO task) {
        return task.getReviewerId() == null && task.getReviewTime() != null;
    }

    /**
     * 获取用户昵称
     *
     * @param userId 用户编号
     * @return 昵称，用户不存在时返回 null
     */
    private String getUserNickname(Long userId) {
        if (userId == null) {
            return null;
        }
        AdminUserRespDTO user = adminUserApi.getUser(userId);
        return user == null ? null : user.getNickname();
    }

    private Long getCurrentUserId() {
        Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
        if (authentication != null && authentication.getPrincipal() instanceof Long) {
            return (Long) authentication.getPrincipal();
        }
        return 1L; // 默认用户
    }

    @Override
@@ -159,6 +308,8 @@
        }
        task.setStatus(MesWmStockTakingTaskStatusEnum.CANCELED.getStatus());
        stockTakingTaskMapper.updateById(task);
        // 取消后清空审核标记，避免残留审批标记影响后续重新开始盘点
        stockTakingTaskMapper.clearAuditInfo(id);
        if (Boolean.TRUE.equals(task.getFrozen())) {
            updateMaterialStockFrozen(stockTakingTaskLineService.getStockTakingTaskLineListByTaskId(id), false);
        }
@@ -220,4 +371,62 @@
        }
    }

    /**
     * 自动核销盘点差异：按盘点结果逐行生成 IN/OUT 库存事务更新库存台账
     *
     * <p>仅由 {@link #auditStockTakingResult} 的审核通过分支在同事务内调用；
     * 失败整体回滚，任务回退为盘点中状态，避免重复调整。
     *
     * @param task 已置为已完成、已解冻的盘点任务
     */
    private void doProcessStockTakingDifference(MesWmStockTakingTaskDO task) {
        // 1. 获取盘点结果列表
        List<MesWmStockTakingTaskResultDO> results = stockTakingTaskResultService.getStockTakingTaskResultListByTaskId(task.getId());
        if (CollUtil.isEmpty(results)) {
            return; // 无盘点结果，无需处理
        }

        // 2. 建立 行号 -> 盘点行 映射：以盘点行（库存快照）为准回填库存编号与维度，
        //    避免出库核销按 (物料+位置+批次) 组合键匹配到其它供应商/库位的账面行而扣错库存
        Map<Long, MesWmStockTakingTaskLineDO> lineMap = convertMap(
                stockTakingTaskLineService.getStockTakingTaskLineListByTaskId(task.getId()),
                MesWmStockTakingTaskLineDO::getId);

        // 3. 遍历结果，处理差异
        for (MesWmStockTakingTaskResultDO result : results) {
            BigDecimal bookQuantity = result.getQuantity();          // 账面数量
            BigDecimal takingQuantity = result.getTakingQuantity(); // 盘点数量

            if (takingQuantity == null || bookQuantity == null) {
                continue;
            }

            // 计算差异：盘点数量 - 账面数量（盘盈为正、盘亏为负）
            BigDecimal difference = takingQuantity.subtract(bookQuantity);
            if (difference.compareTo(BigDecimal.ZERO) == 0) {
                continue; // 无差异，跳过
            }

            MesWmStockTakingTaskLineDO line = result.getLineId() != null ? lineMap.get(result.getLineId()) : null;

            // 4. 创建库存调整事务：盘盈传正数入库；盘亏直接传负数出库（createTransaction 校验出库数量必须为负）
            MesWmTransactionSaveReqDTO transaction = new MesWmTransactionSaveReqDTO()
                    .setType(difference.compareTo(BigDecimal.ZERO) > 0
                            ? MesWmTransactionTypeEnum.IN.getType() : MesWmTransactionTypeEnum.OUT.getType())
                    .setQuantity(difference)
                    .setItemId(line != null ? line.getItemId() : result.getItemId())
                    .setBatchId(line != null ? line.getBatchId() : result.getBatchId())
                    .setBatchCode(line != null ? line.getBatchCode() : result.getBatchCode())
                    .setWarehouseId(line != null ? line.getWarehouseId() : result.getWarehouseId())
                    .setLocationId(line != null ? line.getLocationId() : result.getLocationId())
                    .setAreaId(line != null ? line.getAreaId() : result.getAreaId())
                    .setMaterialStockId(line != null ? line.getMaterialStockId() : result.getMaterialStockId())
                    .setBizId(task.getId())
                    .setBizCode(task.getCode())
                    .setBizLineId(result.getLineId())
                    .setBizType(MesBizTypeConstants.WM_STOCK_TAKING);
            wmTransactionService.createTransaction(transaction);
        }
    }

}