From 7d2ee3cef2e0d68ba6400bc5957640d2771bbf4c Mon Sep 17 00:00:00 2001
From: liu <2021943741@qq.com>
Date: 星期三, 16 九月 2026 18:05:40 +0800
Subject: [PATCH] refactor: 单据审核改为审批配置状态机(新增:audit接口/审核人字段/DB变更脚本)

---
 yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java |  139 ++++++++++++++++++++++------------------------
 1 files changed, 67 insertions(+), 72 deletions(-)

diff --git a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java
index f15ad92..baadd8c 100644
--- a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java
+++ b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/itemreceipt/MesWmItemReceiptServiceImpl.java
@@ -16,21 +16,20 @@
 import cn.iocoder.yudao.module.mes.enums.MesBizTypeConstants;
 import cn.iocoder.yudao.module.mes.enums.wm.MesWmItemReceiptStatusEnum;
 import cn.iocoder.yudao.module.mes.enums.wm.MesWmTransactionTypeEnum;
-import cn.iocoder.yudao.module.bpm.enums.task.BpmTaskStatusEnum;
 import cn.iocoder.yudao.module.mes.service.qc.iqc.MesQcIqcService;
 import cn.iocoder.yudao.module.mes.service.wm.arrivalnotice.MesWmArrivalNoticeService;
 import cn.iocoder.yudao.module.mes.service.wm.arrivalnotice.MesWmArrivalNoticeLineService;
 import cn.iocoder.yudao.module.mes.dal.dataobject.wm.arrivalnotice.MesWmArrivalNoticeLineDO;
 import cn.iocoder.yudao.module.mes.service.wm.transaction.MesWmTransactionService;
 import cn.iocoder.yudao.module.mes.service.wm.transaction.dto.MesWmTransactionSaveReqDTO;
-import cn.iocoder.yudao.module.bpm.api.task.BpmProcessInstanceApi;
-import cn.iocoder.yudao.module.bpm.api.task.dto.BpmProcessInstanceCreateReqDTO;
 import cn.iocoder.yudao.module.erp.api.purchase.PurchaseOrderApi;
 import cn.iocoder.yudao.module.srm.api.supplier.SrmSupplierApi;
 import cn.iocoder.yudao.module.mdm.api.item.MdmItemApi;
 import cn.iocoder.yudao.module.mdm.api.item.dto.MdmItemRespDTO;
-import org.springframework.security.core.Authentication;
-import org.springframework.security.core.context.SecurityContextHolder;
+import cn.iocoder.yudao.module.system.api.approval.ApprovalConfigApi;
+import cn.iocoder.yudao.module.system.api.user.AdminUserApi;
+import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO;
+import cn.hutool.core.util.StrUtil;
 import jakarta.annotation.Resource;
 import org.springframework.context.annotation.Lazy;
 import org.springframework.stereotype.Service;
@@ -42,9 +41,11 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
 import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertList;
+import static cn.iocoder.yudao.framework.security.core.util.SecurityFrameworkUtils.getLoginUserId;
 import static cn.iocoder.yudao.module.mes.enums.ErrorCodeConstants.*;
 
 /**
@@ -54,6 +55,13 @@
 @Validated
 @Slf4j
 public class MesWmItemReceiptServiceImpl implements MesWmItemReceiptService {
+
+    /**
+     * 閲囪喘鍏ュ簱鍗曞鎵圭殑涓氬姟绫诲瀷缂栫爜
+     *
+     * 涓� system_approval_config.biz_type 瀵瑰簲锛屽鏍镐汉鍦ㄣ�岀郴缁熺鐞� - 瀹℃壒閰嶇疆銆嶄腑缁存姢銆�
+     */
+    private static final String ITEM_RECEIPT_APPROVE_BIZ_TYPE = "item_receipt_approve";
 
     @Resource
     private MesWmItemReceiptMapper itemReceiptMapper;
@@ -78,7 +86,10 @@
     private MesWmArrivalNoticeLineService arrivalNoticeLineService;
 
     @Resource
-    private BpmProcessInstanceApi processInstanceApi;
+    private AdminUserApi adminUserApi;
+
+    @Resource
+    private ApprovalConfigApi approvalConfigApi;
 
     @Resource
     private PurchaseOrderApi purchaseOrderApi;
@@ -165,9 +176,56 @@
         // 鏍¢獙鐗╂枡鎵规绠$悊锛氬鏋滅墿鏂欏紑鍚壒娆$鐞嗭紝鍒欐槑缁嗙殑鎵规鍙蜂笉鑳戒负绌�
         validateBatchManagement(lines);
 
-        // 鎻愪氦锛堣崏绋� 鈫� 寰呬笂鏋讹級
-        itemReceiptMapper.updateById(new MesWmItemReceiptDO()
-                .setId(id).setStatus(MesWmItemReceiptStatusEnum.APPROVING.getStatus()));
+        // 鏍¢獙瀹℃壒閰嶇疆宸插惎鐢ㄤ笖閰嶇疆浜嗘湁鏁堝鏍镐汉锛堟湭閰嶇疆鏃舵姏鍑哄甫鏄庣‘鎻愮ず鐨勪笟鍔″紓甯革級
+        approvalConfigApi.validateApprovalEnabledAndGetApprovers(ITEM_RECEIPT_APPROVE_BIZ_TYPE);
+
+        // 鎻愪氦锛堣崏绋� 鈫� 寰呬笂鏋讹級锛屽苟娓呯┖涓婁竴杞鏍哥粨鏋�
+        itemReceiptMapper.submitAndResetAuditInfo(id, MesWmItemReceiptStatusEnum.APPROVING.getStatus());
+    }
+
+    @Override
+    public Set<Long> getItemReceiptApproverUserIds() {
+        return approvalConfigApi.getApproverUserIds(ITEM_RECEIPT_APPROVE_BIZ_TYPE);
+    }
+
+    @Override
+    @Transactional(rollbackFor = Exception.class)
+    public void auditItemReceipt(Long id, Boolean pass, String reviewRemark) {
+        // 1. 鏍¢獙瀛樺湪
+        MesWmItemReceiptDO receipt = validateItemReceiptExists(id);
+        // 2. 鏍¢獙澶勪簬寰呬笂鏋剁姸鎬�
+        if (!MesWmItemReceiptStatusEnum.APPROVING.getStatus().equals(receipt.getStatus())) {
+            throw exception(WM_ITEM_RECEIPT_NOT_APPROVING);
+        }
+        // 3. 鏍¢獙褰撳墠鐧诲綍鐢ㄦ埛鏄涓氬姟绫诲瀷鐨勫鏍镐汉锛堟垨绛撅細浠讳竴浜哄潎鍙鏍革級
+        Long userId = getLoginUserId();
+        approvalConfigApi.validateApprover(ITEM_RECEIPT_APPROVE_BIZ_TYPE, userId);
+        // 4. 瀹℃牳涓嶉�氳繃锛氬繀椤诲~鍐欏師鍥狅紝閫�鍥炶崏绋垮彲淇敼鍚庨噸鏂版彁浜�
+        if (!Boolean.TRUE.equals(pass)) {
+            if (StrUtil.isBlank(reviewRemark)) {
+                throw exception(WM_ITEM_RECEIPT_REJECT_REASON_REQUIRED);
+            }
+            itemReceiptMapper.auditItemReceipt(id, MesWmItemReceiptStatusEnum.PREPARE.getStatus(),
+                    userId, getUserNickname(userId), reviewRemark);
+            return;
+        }
+        // 5. 瀹℃牳閫氳繃锛氳褰曞鏍镐汉涓庡鏍告剰瑙侊紝鐘舵�佺疆涓哄緟鎵ц鍏ュ簱
+        itemReceiptMapper.auditItemReceipt(id, MesWmItemReceiptStatusEnum.APPROVED.getStatus(),
+                userId, getUserNickname(userId), reviewRemark);
+    }
+
+    /**
+     * 鑾峰彇鐢ㄦ埛鏄电О
+     *
+     * @param userId 鐢ㄦ埛缂栧彿
+     * @return 鏄电О锛岀敤鎴蜂笉瀛樺湪鏃惰繑鍥� null
+     */
+    private String getUserNickname(Long userId) {
+        if (userId == null) {
+            return null;
+        }
+        AdminUserRespDTO user = adminUserApi.getUser(userId);
+        return user == null ? null : user.getNickname();
     }
 
     /**
@@ -443,69 +501,6 @@
         }
 
         return receipt.getId();
-    }
-
-    @Override
-    @Transactional(rollbackFor = Exception.class)
-    public void submitItemReceiptApproval(Long id, String processDefinitionKey) {
-        // 1. 鏍¢獙瀛樺湪 + 鑽夌鐘舵��
-        validateItemReceiptExistsAndDraft(id);
-
-        // 2. 鍒涘缓 BPM 娴佺▼瀹炰緥
-        Long userId = getCurrentUserId();
-        String processInstanceId = processInstanceApi.createProcessInstance(userId,
-                new BpmProcessInstanceCreateReqDTO()
-                        .setProcessDefinitionKey(processDefinitionKey)
-                        .setBusinessKey(String.valueOf(id)));
-
-        // 3. 鏇存柊鍏ュ簱鍗曠姸鎬佷负瀹℃壒涓�
-        itemReceiptMapper.updateById(new MesWmItemReceiptDO()
-                .setId(id)
-                .setStatus(MesWmItemReceiptStatusEnum.APPROVING.getStatus())
-                .setProcessInstanceId(processInstanceId));
-    }
-
-    @Override
-    @Transactional(rollbackFor = Exception.class)
-    public void updateItemReceiptAuditStatus(Long id, Integer bpmResult) {
-        // 1. 鏍¢獙瀛樺湪
-        MesWmItemReceiptDO receipt = validateItemReceiptExists(id);
-        if (!MesWmItemReceiptStatusEnum.APPROVING.getStatus().equals(receipt.getStatus())) {
-            log.warn("[updateItemReceiptAuditStatus] 鍏ュ簱鍗�({}) 涓嶅浜庡鎵逛腑鐘舵��", id);
-            return;
-        }
-
-        // 2. 鏍规嵁瀹℃壒缁撴灉鏇存柊鐘舵��
-        Integer newStatus = convertBpmResultToReceiptStatus(bpmResult);
-        if (newStatus != null) {
-            itemReceiptMapper.updateById(new MesWmItemReceiptDO()
-                    .setId(id).setStatus(newStatus));
-        }
-    }
-
-    /**
-     * 杞崲 BPM 瀹℃壒缁撴灉涓哄叆搴撳崟鐘舵��
-     */
-    private Integer convertBpmResultToReceiptStatus(Integer bpmResult) {
-        if (BpmTaskStatusEnum.APPROVE.getStatus().equals(bpmResult)) {
-            return MesWmItemReceiptStatusEnum.APPROVED.getStatus();
-        } else if (BpmTaskStatusEnum.REJECT.getStatus().equals(bpmResult)) {
-            return MesWmItemReceiptStatusEnum.PREPARE.getStatus();
-        } else if (BpmTaskStatusEnum.CANCEL.getStatus().equals(bpmResult)) {
-            return MesWmItemReceiptStatusEnum.CANCELED.getStatus();
-        }
-        return null;
-    }
-
-    /**
-     * 鑾峰彇褰撳墠鐢ㄦ埛 ID
-     */
-    private Long getCurrentUserId() {
-        Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
-        if (authentication != null && authentication.getPrincipal() instanceof Long) {
-            return (Long) authentication.getPrincipal();
-        }
-        return 1L; // 榛樿鐢ㄦ埛
     }
 
     /**

--
Gitblit v1.9.3