From 962f78c8383e7c884ddb08c951c15e5ba6eb4cb8 Mon Sep 17 00:00:00 2001
From: liu <2021943741@qq.com>
Date: 星期五, 23 十月 2026 15:43:33 +0800
Subject: [PATCH] fix: 完善审批流程与业务状态校验
---
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pd/project/MesPdProjectServiceImpl.java | 167 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
1 files changed, 156 insertions(+), 11 deletions(-)
diff --git a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pd/project/MesPdProjectServiceImpl.java b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pd/project/MesPdProjectServiceImpl.java
index 729076a..c7c4a34 100644
--- a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pd/project/MesPdProjectServiceImpl.java
+++ b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/pd/project/MesPdProjectServiceImpl.java
@@ -1,6 +1,11 @@
package cn.iocoder.yudao.module.mes.service.pd.project;
+import cn.hutool.core.collection.CollUtil;
+import cn.hutool.core.util.ObjUtil;
+import cn.hutool.core.util.StrUtil;
import cn.iocoder.yudao.framework.common.pojo.PageResult;
+import cn.iocoder.yudao.module.mes.controller.admin.pd.project.vo.MesPdProjectImportExcelVO;
+import cn.iocoder.yudao.module.mes.controller.admin.pd.project.vo.MesPdProjectImportRespVO;
import cn.iocoder.yudao.module.mes.controller.admin.pd.project.vo.MesPdProjectPageReqVO;
import cn.iocoder.yudao.module.mes.controller.admin.pd.project.vo.MesPdProjectSaveReqVO;
import cn.iocoder.yudao.module.mes.dal.dataobject.pd.document.MesPdDocumentDO;
@@ -14,30 +19,47 @@
import cn.iocoder.yudao.module.mes.enums.pd.MesPdProjectStatusEnum;
import cn.iocoder.yudao.module.mes.service.md.autocode.MesMdAutoCodeRecordService;
import cn.iocoder.yudao.module.mes.service.pd.document.MesPdDocumentService;
+import cn.iocoder.yudao.module.system.api.approval.ApprovalConfigApi;
+import cn.iocoder.yudao.module.system.api.user.AdminUserApi;
+import cn.iocoder.yudao.module.system.api.user.dto.AdminUserRespDTO;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import jakarta.annotation.Resource;
+import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import org.springframework.validation.annotation.Validated;
import java.time.LocalDateTime;
+import java.util.ArrayList;
import java.util.Collection;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertMap;
+import static cn.iocoder.yudao.framework.security.core.util.SecurityFrameworkUtils.getLoginUserId;
import static cn.iocoder.yudao.module.mes.enums.ErrorCodeConstants.*;
/**
* MES 璁捐椤圭洰 Service 瀹炵幇绫�
*
- * @author 鑺嬮亾婧愮爜
+ * @author 瓒呯骇绠＄悊鍛�
*/
@Service
@Validated
+@Slf4j
public class MesPdProjectServiceImpl implements MesPdProjectService {
+
+ /**
+ * 璁捐椤圭洰瀹℃壒鐨勪笟鍔＄被鍨嬬紪鐮�
+ *
+ * 涓� system_approval_config.biz_type 瀵瑰簲锛屽鏍镐汉鍦ㄣ�岀郴缁熺鐞� - 瀹℃壒閰嶇疆銆嶄腑缁存姢銆�
+ */
+ private static final String PROJECT_APPROVE_BIZ_TYPE = "mes_pd_project_approve";
@Resource
private MesPdProjectMapper projectMapper;
@@ -55,6 +77,12 @@
@Resource
@Lazy
private MesMdAutoCodeRecordService autoCodeRecordService;
+
+ @Resource
+ private AdminUserApi adminUserApi;
+
+ @Resource
+ private ApprovalConfigApi approvalConfigApi;
@Override
@Transactional(rollbackFor = Exception.class)
@@ -180,24 +208,71 @@
}
@Override
- public void auditProject(Long id) {
- // 鏍￠獙瀛樺湪
+ @Transactional(rollbackFor = Exception.class)
+ public void submitProjectApproval(Long id) {
+ // 1. 鏍￠獙瀛樺湪 + 寰呭鏍哥姸鎬�
MesPdProjectDO project = validateProjectExists(id);
- // 鏍￠獙鐘舵�佷负寰呭鏍�
if (!MesPdProjectStatusEnum.UPLOAD.getStatus().equals(project.getStatus())) {
- throw exception(PD_PROJECT_NOT_UPLOAD_FOR_AUDIT);
+ throw exception(PD_PROJECT_NOT_UPLOAD_FOR_APPROVAL);
}
- // 鏍￠獙璇ラ」鐩笅鎵�鏈夎祫鏂欏鏍歌褰曞潎宸插鏍革紙涓嶅瓨鍦ㄥ緟瀹℃牳鐨勮褰曪級
+ // 2. 鏍￠獙璇ラ」鐩笅鎵�鏈夎祫鏂欏鏍歌褰曞潎宸插鏍革紙涓嶅瓨鍦ㄥ緟瀹℃牳鐨勮褰曪級
List<MesPdDocumentDO> documents = documentService.getDocumentListByProjectId(id);
+ if (CollUtil.isEmpty(documents)) {
+ throw exception(PD_PROJECT_NO_DOCUMENT);
+ }
List<Long> documentIds = documents.stream().map(MesPdDocumentDO::getId).toList();
if (documentAuditMapper.existsPendingAuditByDocumentIds(documentIds)) {
throw exception(PD_PROJECT_AUDIT_NOT_FINISHED);
}
- // 鏇存柊鐘舵��
- projectMapper.updateById(MesPdProjectDO.builder()
- .id(id)
- .status(MesPdProjectStatusEnum.AUDIT.getStatus())
- .build());
+ // 3. 鏍￠獙瀹℃壒閰嶇疆宸插惎鐢ㄤ笖閰嶇疆浜嗘湁鏁堝鏍镐汉锛堟湭閰嶇疆鏃舵姏鍑哄甫鏄庣‘鎻愮ず鐨勪笟鍔″紓甯革級
+ approvalConfigApi.validateApprovalEnabledAndGetApprovers(PROJECT_APPROVE_BIZ_TYPE);
+ // 4. 鐘舵�佺疆涓哄鎵逛腑锛屽苟娓呯┖涓婁竴杞鏍哥粨鏋�
+ projectMapper.submitAndResetAuditInfo(id, MesPdProjectStatusEnum.APPROVING.getStatus());
+ }
+
+ @Override
+ public Set<Long> getProjectApproverUserIds() {
+ return approvalConfigApi.getApproverUserIds(PROJECT_APPROVE_BIZ_TYPE);
+ }
+
+ @Override
+ @Transactional(rollbackFor = Exception.class)
+ public void auditProject(Long id, Boolean pass, String reviewRemark) {
+ // 1. 鏍￠獙瀛樺湪
+ MesPdProjectDO project = validateProjectExists(id);
+ // 2. 鏍￠獙澶勪簬瀹℃壒涓姸鎬�
+ if (!MesPdProjectStatusEnum.APPROVING.getStatus().equals(project.getStatus())) {
+ throw exception(PD_PROJECT_NOT_APPROVING);
+ }
+ // 3. 鏍￠獙褰撳墠鐧诲綍鐢ㄦ埛鏄涓氬姟绫诲瀷鐨勫鏍镐汉锛堟垨绛撅細浠讳竴浜哄潎鍙鏍革級
+ Long userId = getLoginUserId();
+ approvalConfigApi.validateApprover(PROJECT_APPROVE_BIZ_TYPE, userId);
+ // 4. 瀹℃牳涓嶉�氳繃锛氬繀椤诲～鍐欏師鍥狅紝閫�鍥炲緟瀹℃牳鐘舵�侊紝鍙慨鏀瑰悗閲嶆柊鎻愪氦
+ if (!Boolean.TRUE.equals(pass)) {
+ if (StrUtil.isBlank(reviewRemark)) {
+ throw exception(PD_PROJECT_AUDIT_REJECT_REASON_REQUIRED);
+ }
+ projectMapper.auditProject(id, MesPdProjectStatusEnum.UPLOAD.getStatus(),
+ userId, getUserNickname(userId), reviewRemark);
+ return;
+ }
+ // 5. 瀹℃牳閫氳繃锛氳褰曞鏍镐汉涓庡鏍告剰瑙侊紝鐘舵�佺疆涓哄緟褰掓。
+ projectMapper.auditProject(id, MesPdProjectStatusEnum.AUDIT.getStatus(),
+ userId, getUserNickname(userId), reviewRemark);
+ }
+
+ /**
+ * 鑾峰彇鐢ㄦ埛鏄电О
+ *
+ * @param userId 鐢ㄦ埛缂栧彿
+ * @return 鏄电О锛岀敤鎴蜂笉瀛樺湪鏃惰繑鍥� null
+ */
+ private String getUserNickname(Long userId) {
+ if (userId == null) {
+ return null;
+ }
+ AdminUserRespDTO user = adminUserApi.getUser(userId);
+ return user == null ? null : user.getNickname();
}
@Override
@@ -257,6 +332,76 @@
}
}
+ @Override
+ @Transactional(rollbackFor = Exception.class)
+ public MesPdProjectImportRespVO importProjectList(List<MesPdProjectImportExcelVO> importList,
+ boolean updateSupport) {
+ // 1. 鏍￠獙闈炵┖
+ if (CollUtil.isEmpty(importList)) {
+ throw exception(PD_PROJECT_IMPORT_LIST_IS_EMPTY);
+ }
+
+ // 2. 閫愯澶勭悊
+ MesPdProjectImportRespVO respVO = MesPdProjectImportRespVO.builder()
+ .createCodes(new ArrayList<>()).updateCodes(new ArrayList<>())
+ .failureCodes(new LinkedHashMap<>()).build();
+ AtomicInteger index = new AtomicInteger(1);
+ importList.forEach(importItem -> {
+ int currentIndex = index.getAndIncrement();
+ String key = StrUtil.blankToDefault(importItem.getTaskCode(), "绗� " + currentIndex + " 琛�");
+ if (StrUtil.isBlank(importItem.getTaskCode())) {
+ respVO.getFailureCodes().put(key, "浠诲姟缂栫爜涓嶈兘涓虹┖");
+ return;
+ }
+ if (StrUtil.isBlank(importItem.getTaskName())) {
+ respVO.getFailureCodes().put(key, "浠诲姟鍚嶇О涓嶈兘涓虹┖");
+ return;
+ }
+ // 2.1 鍒ゆ柇锛氬垱寤� or 鏇存柊
+ MesPdProjectDO existProject = projectMapper.selectByTaskCode(importItem.getTaskCode());
+ if (existProject == null) {
+ // 2.1.1 鏂板锛堝鐢� create 鐨勭姸鎬佸垵濮嬪寲閫昏緫锛�
+ MesPdProjectDO project = MesPdProjectDO.builder()
+ .taskCode(importItem.getTaskCode())
+ .taskName(importItem.getTaskName())
+ .productCode(importItem.getProductCode())
+ .productName(importItem.getProductName())
+ .version(importItem.getVersion())
+ .status(MesPdProjectStatusEnum.INITIATE.getStatus())
+ .chiefDesigner(importItem.getChiefDesigner())
+ .reviewer(importItem.getReviewer())
+ .planFinishTime(importItem.getPlanFinishTime())
+ .remark(importItem.getRemark())
+ .build();
+ projectMapper.insert(project);
+ respVO.getCreateCodes().add(importItem.getTaskCode());
+ } else if (updateSupport) {
+ // 2.1.2 鏇存柊锛堜粎寰呭彂甯冪姸鎬佸彲鏇存柊锛�
+ if (ObjUtil.notEqual(MesPdProjectStatusEnum.INITIATE.getStatus(), existProject.getStatus())) {
+ respVO.getFailureCodes().put(key, "浠呭緟鍙戝竷鐘舵�佺殑璁捐椤圭洰鍙洿鏂�");
+ return;
+ }
+ MesPdProjectDO updateObj = MesPdProjectDO.builder()
+ .id(existProject.getId())
+ .taskCode(importItem.getTaskCode())
+ .taskName(importItem.getTaskName())
+ .productCode(importItem.getProductCode())
+ .productName(importItem.getProductName())
+ .version(importItem.getVersion())
+ .chiefDesigner(importItem.getChiefDesigner())
+ .reviewer(importItem.getReviewer())
+ .planFinishTime(importItem.getPlanFinishTime())
+ .remark(importItem.getRemark())
+ .build();
+ projectMapper.updateById(updateObj);
+ respVO.getUpdateCodes().add(importItem.getTaskCode());
+ } else {
+ respVO.getFailureCodes().put(key, "浠诲姟缂栫爜宸插瓨鍦�");
+ }
+ });
+ return respVO;
+ }
+
/**
* 鐢熸垚瀹℃牳鍗曞彿锛堜娇鐢ㄧ紪鐮佽鍒欙級
*/
--
Gitblit v1.9.3