From ac2e2b5af3726ee64dc37c3ebf26989a0346f22a Mon Sep 17 00:00:00 2001
From: 云 <2163098428@qq.com>
Date: 星期六, 07 十一月 2026 19:16:05 +0800
Subject: [PATCH] feat(feedback): 优化报工审批流程并增加报工人校验
---
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/md/item/MesMdItemServiceImpl.java | 57 ++++++++++++++++++++++++++++++++++++++++++++-------------
1 files changed, 44 insertions(+), 13 deletions(-)
diff --git a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/md/item/MesMdItemServiceImpl.java b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/md/item/MesMdItemServiceImpl.java
index 0899d3a..afcd3b4 100644
--- a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/md/item/MesMdItemServiceImpl.java
+++ b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/md/item/MesMdItemServiceImpl.java
@@ -2,6 +2,7 @@
import cn.hutool.core.collection.CollUtil;
import cn.hutool.core.util.ObjUtil;
+import cn.hutool.core.util.StrUtil;
import cn.iocoder.yudao.framework.common.pojo.PageResult;
import cn.iocoder.yudao.framework.common.util.object.BeanUtils;
import cn.iocoder.yudao.module.mes.controller.admin.md.item.vo.MesMdItemPageReqVO;
@@ -37,7 +38,7 @@
*
* 鏀寔 MES 鍜� MDM 鐗╂枡鏁版嵁鍙屽悜鍚屾
*
- * @author 鑺嬮亾婧愮爜
+ * @author 瓒呯骇绠$悊鍛�
*/
@Service
@Validated
@@ -80,11 +81,19 @@
updateItem(createReqVO);
return createReqVO.getId();
}
+ // 瀛樺湪閫昏緫鍒犻櫎璁板綍锛堝彇娑堝悓姝ュ悗閲嶆柊鍚屾锛夛細鎭㈠璇ヨ褰曞悗璧版洿鏂帮紝閬垮厤涓婚敭鍐茬獊
+ if (itemMapper.selectAnyById(createReqVO.getId()) != null) {
+ itemMapper.restoreById(createReqVO.getId());
+ updateItem(createReqVO);
+ return createReqVO.getId();
+ }
}
// 鎻掑叆
MesMdItemDO item = BeanUtils.toBean(createReqVO, MesMdItemDO.class);
- item.setStatus(CommonStatusEnum.DISABLE.getStatus()); // 榛樿绂佺敤銆備俊鎭畬鎴愬悗锛屽啀鍚敤
+ // 鐘舵�佸彧鑳界敱鍩虹鏁版嵁锛圡DM锛夋帶鍒讹細MDM 鍚屾鏃舵部鐢ㄥ叾鐘舵�侊紱MES 鏈湴鏂板榛樿绂佺敤
+ item.setStatus(createReqVO.getMdmItemId() != null && createReqVO.getStatus() != null
+ ? createReqVO.getStatus() : CommonStatusEnum.DISABLE.getStatus());
clearStockIfNotSafe(item); // 濡傛灉鏈惎鐢ㄥ畨鍏ㄥ簱瀛橈紝娓呴浂搴撳瓨涓婁笅闄�
itemMapper.insert(item);
@@ -104,13 +113,17 @@
@Transactional(rollbackFor = Exception.class)
public void updateItem(MesMdItemSaveReqVO updateReqVO) {
// 鏍¢獙瀛樺湪
- validateItemExists(updateReqVO.getId());
+ MesMdItemDO existingItem = validateItemExists(updateReqVO.getId());
// 鏍¢獙鏁版嵁
- validateItemSaveData(updateReqVO);
+ validateItemSaveData(updateReqVO, existingItem);
// 鏇存柊
MesMdItemDO updateObj = BeanUtils.toBean(updateReqVO, MesMdItemDO.class);
clearStockIfNotSafe(updateObj); // 濡傛灉鏈惎鐢ㄥ畨鍏ㄥ簱瀛橈紝娓呴浂搴撳瓨涓婁笅闄�
+ // 鐘舵�佸彧鑳界敱鍩虹鏁版嵁锛圡DM锛夋帶鍒讹紝MES 鏈湴鏇存柊涓嶅厑璁镐慨鏀圭姸鎬�
+ if (updateReqVO.getMdmItemId() == null) {
+ updateObj.setStatus(null);
+ }
itemMapper.updateById(updateObj);
// 鍚屾鍒� MDM锛堝嬀閫� syncMdm 鏃讹級
@@ -121,10 +134,19 @@
}
private void validateItemSaveData(MesMdItemSaveReqVO reqVO) {
+ validateItemSaveData(reqVO, null);
+ }
+
+ private void validateItemSaveData(MesMdItemSaveReqVO reqVO, MesMdItemDO existingItem) {
// 鏍¢獙鐗╂枡缂栫爜鐨勫敮涓�鎬�
validateItemCodeUnique(reqVO.getId(), reqVO.getCode());
- // 鏍¢獙鐗╂枡鍚嶇О鐨勫敮涓�鎬�
- validateItemNameUnique(reqVO.getId(), reqVO.getName());
+ // 鏍¢獙鐗╂枡鍚嶇О鐨勫敮涓�鎬э細MDM 涓绘暟鎹互缂栫爜涓哄敮涓�鏍囪瘑锛屽厑璁稿悓鍚嶄笉鍚岃鏍笺��
+ // 鏇存柊鏃跺墠绔彲鑳芥湭鍥炰紶 mdmItemId锛岄渶瑕佷互搴撲腑璁板綍鐨勬潵婧愪负鍑嗭紝鍚﹀垯浼氳鍒や负鏈湴鐗╂枡
+ boolean mdmItem = reqVO.getMdmItemId() != null
+ || (existingItem != null && existingItem.getMdmItemId() != null);
+ if (!mdmItem) {
+ validateItemNameUnique(reqVO.getId(), reqVO.getName());
+ }
// 鏍¢獙鐗╂枡鍒嗙被瀛樺湪
validateItemTypeExists(reqVO.getItemTypeId());
// 鏍¢獙璁¢噺鍗曚綅瀛樺湪
@@ -200,11 +222,9 @@
}
private void validateItemNameUnique(Long id, String name) {
- MesMdItemDO item = itemMapper.selectByName(name);
- if (item == null) {
- return;
- }
- if (ObjUtil.notEqual(item.getId(), id)) {
+ // 浣跨敤鍒楄〃鏌ヨ锛氬瓨閲忔暟鎹彲鑳藉瓨鍦ㄥ悓鍚嶇墿鏂欙紝閬垮厤 selectOne 鐩存帴鎶涘紓甯�
+ List<MesMdItemDO> items = itemMapper.selectList(MesMdItemDO::getName, name);
+ if (items.stream().anyMatch(item -> ObjUtil.notEqual(item.getId(), id))) {
throw exception(MD_ITEM_NAME_DUPLICATE);
}
}
@@ -278,8 +298,19 @@
List<MesMdItemTypeDO> children = itemTypeService.getItemTypeChildrenList(pageReqVO.getItemTypeId());
itemTypeIds.addAll(convertSet(children, MesMdItemTypeDO::getId));
}
+ // 鐢熶骇鐗╂枡绠$悊绛夐〉闈㈠彲鎸夊垎绫荤紪鐮佹帓闄よ澶囧強鍏跺瓙鍒嗙被锛涘簳灞傝澶囦富鏁版嵁浠嶄繚鐣欑粰璁惧浠撳拰搴撳瓨娴佹按浣跨敤銆�
+ Set<Long> excludedItemTypeIds = null;
+ if (StrUtil.isNotBlank(pageReqVO.getExcludeItemTypeCode())) {
+ MesMdItemTypeDO excludedType = itemTypeService.getItemTypeByCode(pageReqVO.getExcludeItemTypeCode());
+ if (excludedType != null) {
+ excludedItemTypeIds = new HashSet<>();
+ excludedItemTypeIds.add(excludedType.getId());
+ List<MesMdItemTypeDO> children = itemTypeService.getItemTypeChildrenList(excludedType.getId());
+ excludedItemTypeIds.addAll(convertSet(children, MesMdItemTypeDO::getId));
+ }
+ }
// 鍒嗛〉鏌ヨ
- return itemMapper.selectPage(pageReqVO, itemTypeIds);
+ return itemMapper.selectPage(pageReqVO, itemTypeIds, excludedItemTypeIds);
}
@Override
@@ -407,4 +438,4 @@
return item;
}
-}
\ No newline at end of file
+}
--
Gitblit v1.9.3