From f02d0df2f1dfc7a8b775cf50d45375e57628a5ef Mon Sep 17 00:00:00 2001
From: 云 <2163098428@qq.com>
Date: 星期二, 10 十一月 2026 11:26:22 +0800
Subject: [PATCH] feat(ncr): 完善NCR处置联动逻辑与关闭校验
---
yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java
index 41bd4b3..af8ffcd 100644
--- a/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java
+++ b/yudao-module-mes/src/main/java/cn/iocoder/yudao/module/mes/service/wm/returnsales/MesWmReturnSalesServiceImpl.java
@@ -34,6 +34,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
import static cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil.exception;
import static cn.iocoder.yudao.framework.common.util.collection.CollectionUtils.convertList;
@@ -166,7 +167,8 @@
@Transactional(rollbackFor = Exception.class)
public void stockReturnSales(Long id) {
// 1.1 鏍￠獙瀛樺湪 + 寰呬笂鏋剁姸鎬�
- MesWmReturnSalesDO returnSales = validateReturnSalesExists(id);
+ MesWmReturnSalesDO returnSales = returnSalesMapper.selectByIdForUpdate(id);
+ if (returnSales == null) throw exception(WM_RETURN_SALES_NOT_EXISTS);
if (ObjUtil.notEqual(MesWmReturnSalesStatusEnum.APPROVED.getStatus(), returnSales.getStatus())) {
throw exception(WM_RETURN_SALES_STATUS_NOT_APPROVED);
}
@@ -182,6 +184,12 @@
allDetails, MesWmReturnSalesDetailDO::getLineId);
// 妫�鏌ユ瘡琛岀殑鏄庣粏鏁伴噺
for (MesWmReturnSalesLineDO line : lines) {
+ if (line.getNcrDispositionId() != null && Objects.equals(line.getQualityStatus(), MesWmQualityStatusEnum.FAIL.getStatus())) {
+ if (!detailMap.getOrDefault(line.getId(), Collections.emptyList()).isEmpty()) {
+ throw exception(WM_RETURN_SALES_LINE_NOT_QUALIFIED);
+ }
+ continue; // 涓嶅悎鏍兼暟閲忕敱 NCR 鐙珛澶勭悊锛屼笉鍦ㄥ師閫�璐у崟鍐嶆鍏ュ簱
+ }
if (ObjUtil.notEqual(line.getQualityStatus(), MesWmQualityStatusEnum.PASS.getStatus())) {
throw exception(WM_RETURN_SALES_LINE_NOT_QUALIFIED);
}
@@ -226,7 +234,8 @@
@Transactional(rollbackFor = Exception.class)
public void cancelReturnSales(Long id) {
// 鏍￠獙瀛樺湪
- MesWmReturnSalesDO returnSales = validateReturnSalesExists(id);
+ MesWmReturnSalesDO returnSales = returnSalesMapper.selectByIdForUpdate(id);
+ if (returnSales == null) throw exception(WM_RETURN_SALES_NOT_EXISTS);
// 宸插畬鎴愬拰宸插彇娑堜笉鍏佽鍙栨秷
if (ObjectUtils.equalsAny(returnSales.getStatus(),
MesWmReturnSalesStatusEnum.FINISHED.getStatus(),
@@ -243,6 +252,9 @@
public Boolean checkReturnSalesQuantity(Long id) {
List<MesWmReturnSalesLineDO> lines = returnSalesLineService.getReturnSalesLineListByReturnId(id);
for (MesWmReturnSalesLineDO line : lines) {
+ if (line.getNcrDispositionId() != null && Objects.equals(line.getQualityStatus(), MesWmQualityStatusEnum.FAIL.getStatus())) {
+ continue;
+ }
List<MesWmReturnSalesDetailDO> details = returnSalesDetailService.getReturnSalesDetailListByLineId(line.getId());
BigDecimal totalDetailQty = CollectionUtils.getSumValue(details,
MesWmReturnSalesDetailDO::getQuantity, BigDecimal::add, BigDecimal.ZERO);
--
Gitblit v1.9.3