From 755c3f7a8acf128ce4545020d07f0b9cf780e52a Mon Sep 17 00:00:00 2001 From: RuoYi <yzz_ivy@163.com> Date: 星期一, 13 六月 2022 21:35:29 +0800 Subject: [PATCH] 优化代码 --- src/main/java/com/ruoyi/framework/aspectj/DataScopeAspect.java | 60 ++++++++++++++++++++---------------------------------------- 1 files changed, 20 insertions(+), 40 deletions(-) diff --git a/src/main/java/com/ruoyi/framework/aspectj/DataScopeAspect.java b/src/main/java/com/ruoyi/framework/aspectj/DataScopeAspect.java index 62e77de..1fb98dc 100644 --- a/src/main/java/com/ruoyi/framework/aspectj/DataScopeAspect.java +++ b/src/main/java/com/ruoyi/framework/aspectj/DataScopeAspect.java @@ -1,26 +1,20 @@ package com.ruoyi.framework.aspectj; -import java.lang.reflect.Method; import org.aspectj.lang.JoinPoint; -import org.aspectj.lang.Signature; import org.aspectj.lang.annotation.Aspect; import org.aspectj.lang.annotation.Before; -import org.aspectj.lang.annotation.Pointcut; -import org.aspectj.lang.reflect.MethodSignature; import org.springframework.stereotype.Component; -import com.ruoyi.common.utils.ServletUtils; +import com.ruoyi.common.utils.SecurityUtils; import com.ruoyi.common.utils.StringUtils; -import com.ruoyi.common.utils.spring.SpringUtils; import com.ruoyi.framework.aspectj.lang.annotation.DataScope; import com.ruoyi.framework.security.LoginUser; -import com.ruoyi.framework.security.service.TokenService; import com.ruoyi.framework.web.domain.BaseEntity; import com.ruoyi.project.system.domain.SysRole; import com.ruoyi.project.system.domain.SysUser; /** * 鏁版嵁杩囨护澶勭悊 - * + * * @author ruoyi */ @Aspect @@ -57,33 +51,22 @@ */ public static final String DATA_SCOPE = "dataScope"; - // 閰嶇疆缁囧叆鐐� - @Pointcut("@annotation(com.ruoyi.framework.aspectj.lang.annotation.DataScope)") - public void dataScopePointCut() + @Before("@annotation(controllerDataScope)") + public void doBefore(JoinPoint point, DataScope controllerDataScope) throws Throwable { + clearDataScope(point); + handleDataScope(point, controllerDataScope); } - @Before("dataScopePointCut()") - public void doBefore(JoinPoint point) throws Throwable + protected void handleDataScope(final JoinPoint joinPoint, DataScope controllerDataScope) { - handleDataScope(point); - } - - protected void handleDataScope(final JoinPoint joinPoint) - { - // 鑾峰緱娉ㄨВ - DataScope controllerDataScope = getAnnotationLog(joinPoint); - if (controllerDataScope == null) - { - return; - } // 鑾峰彇褰撳墠鐨勭敤鎴� - LoginUser loginUser = SpringUtils.getBean(TokenService.class).getLoginUser(ServletUtils.getRequest()); - SysUser currentUser = loginUser.getUser(); - if (currentUser != null) + LoginUser loginUser = SecurityUtils.getLoginUser(); + if (StringUtils.isNotNull(loginUser)) { + SysUser currentUser = loginUser.getUser(); // 濡傛灉鏄秴绾х鐞嗗憳锛屽垯涓嶈繃婊ゆ暟鎹� - if (!currentUser.isAdmin()) + if (StringUtils.isNotNull(currentUser) && !currentUser.isAdmin()) { dataScopeFilter(joinPoint, currentUser, controllerDataScope.deptAlias(), controllerDataScope.userAlias()); @@ -93,10 +76,10 @@ /** * 鏁版嵁鑼冨洿杩囨护 - * + * * @param joinPoint 鍒囩偣 * @param user 鐢ㄦ埛 - * @param alias 鍒悕 + * @param userAlias 鍒悕 */ public static void dataScopeFilter(JoinPoint joinPoint, SysUser user, String deptAlias, String userAlias) { @@ -135,7 +118,7 @@ else { // 鏁版嵁鏉冮檺涓轰粎鏈汉涓旀病鏈塽serAlias鍒悕涓嶆煡璇换浣曟暟鎹� - sqlString.append(" OR 1=0 "); + sqlString.append(StringUtils.format(" OR {}.dept_id = 0 ", deptAlias)); } } } @@ -152,18 +135,15 @@ } /** - * 鏄惁瀛樺湪娉ㄨВ锛屽鏋滃瓨鍦ㄥ氨鑾峰彇 + * 鎷兼帴鏉冮檺sql鍓嶅厛娓呯┖params.dataScope鍙傛暟闃叉娉ㄥ叆 */ - private DataScope getAnnotationLog(JoinPoint joinPoint) + private void clearDataScope(final JoinPoint joinPoint) { - Signature signature = joinPoint.getSignature(); - MethodSignature methodSignature = (MethodSignature) signature; - Method method = methodSignature.getMethod(); - - if (method != null) + Object params = joinPoint.getArgs()[0]; + if (StringUtils.isNotNull(params) && params instanceof BaseEntity) { - return method.getAnnotation(DataScope.class); + BaseEntity baseEntity = (BaseEntity) params; + baseEntity.getParams().put(DATA_SCOPE, ""); } - return null; } } -- Gitblit v1.9.3